labctl: segments sur des bridges de l'hôte, routeurs et passerelle VRRP #2
All checks were successful
Tests / test (push) Successful in 3m46s

Signed-off-by: GnomeZworc <nicolas.boufidjeline@g3e.fr>
This commit is contained in:
GnomeZworc 2026-10-13 09:57:09 +02:00
commit e9a0c19b72
Signed by: nicolas.boufideline
GPG key ID: 4406BBBF8845D632
24 changed files with 1766 additions and 578 deletions

View file

@ -2,6 +2,7 @@ package render
import (
"reflect"
"strconv"
"strings"
"testing"
@ -18,12 +19,12 @@ images:
url: https://example.invalid/deb.qcow2
sums: https://example.invalid/SHA512SUMS
segments:
underlay: { switch: sw1, cidr: 10.250.0.0/24, mtu: 9000 }
underlay: { routers: [sw1], cidr: 10.250.0.0/24, mtu: 9000 }
nodes:
sw1: { role: switch, image: deb, cpus: 2, memory: 1024 }
rr1: { role: rr, image: deb, cpus: 1, memory: 1024, segments: [underlay] }
hv1: { role: host, image: deb, cpus: 4, memory: 16384, segments: [underlay] }
hv2: { role: host, image: deb, cpus: 4, memory: 16384, segments: [underlay] }
sw1: { role: router, image: deb, cpus: 2, memory: 1024, segments: [underlay] }
rr1: { role: rr, image: deb, cpus: 1, memory: 1024, segments: [underlay] }
hv1: { role: host, image: deb, cpus: 4, memory: 16384, segments: [underlay] }
hv2: { role: host, image: deb, cpus: 4, memory: 16384, segments: [underlay] }
`
const twoSegments = `name: two-seg
@ -32,13 +33,30 @@ images:
url: https://example.invalid/deb.qcow2
sums: https://example.invalid/SHA512SUMS
segments:
red: { switch: sw, cidr: 10.1.0.0/24 }
blue: { switch: sw, cidr: 10.2.0.0/24, mtu: 1500 }
red: { routers: [sw], cidr: 10.1.0.0/24 }
blue: { routers: [sw], cidr: 10.2.0.0/24, mtu: 1500 }
nodes:
sw: { role: switch, image: deb, cpus: 1, memory: 512 }
sw: { role: router, image: deb, cpus: 1, memory: 512, segments: [red, blue] }
hv: { role: host, image: deb, cpus: 1, memory: 512, segments: [blue, red] }
`
const withVRRP = `name: vrrp
images:
deb:
url: https://example.invalid/deb.qcow2
sums: https://example.invalid/SHA512SUMS
segments:
red: { routers: [r1, r2], cidr: 10.1.0.0/24 }
blue: { routers: [r1], cidr: 10.2.0.0/24 }
pure: { cidr: 10.3.0.0/24 }
nodes:
r1: { role: router, image: deb, cpus: 1, memory: 512, segments: [red, blue] }
r2: { role: router, image: deb, cpus: 1, memory: 512, segments: [red, pure] }
r3: { role: router, image: deb, cpus: 1, memory: 512, segments: [pure] }
hv: { role: host, image: deb, cpus: 1, memory: 512, segments: [pure, red] }
l2: { role: host, image: deb, cpus: 1, memory: 512, segments: [pure] }
`
func plan(t *testing.T, doc string) *topology.Plan {
t.Helper()
topo, err := topology.Parse([]byte(doc))
@ -182,7 +200,7 @@ func TestQEMU_HypervisorNetwork(t *testing.T) {
hv := nodeNamed(t, renderAll(t, twoHypervisors), "hv1")
wantNetdevs := []string{
"user,id=mgmt0,restrict=on,ipv6=off,hostfwd=tcp:127.0.0.1:2202-:22",
"dgram,id=underlay,local.type=inet,local.host=127.0.0.1,local.port=20002,remote.type=inet,remote.host=127.0.0.1,remote.port=20003",
"tap,id=underlay,ifname=lt2,script=no,downscript=no",
}
wantDevices := []string{
"virtio-net-pci,netdev=mgmt0,mac=02:4d:00:02:00:00,romfile=",
@ -196,27 +214,31 @@ func TestQEMU_HypervisorNetwork(t *testing.T) {
}
}
func TestQEMU_SwitchNetwork(t *testing.T) {
sw := nodeNamed(t, renderAll(t, twoHypervisors), "sw1")
func TestQEMU_RouterNetwork(t *testing.T) {
sw := nodeNamed(t, renderAll(t, twoSegments), "sw")
wantNetdevs := []string{
"user,id=mgmt0,restrict=off,ipv6=off,hostfwd=tcp:127.0.0.1:2200-:22",
"dgram,id=p0,local.type=inet,local.host=127.0.0.1,local.port=20001,remote.type=inet,remote.host=127.0.0.1,remote.port=20000",
"dgram,id=p1,local.type=inet,local.host=127.0.0.1,local.port=20003,remote.type=inet,remote.host=127.0.0.1,remote.port=20002",
"dgram,id=p2,local.type=inet,local.host=127.0.0.1,local.port=20005,remote.type=inet,remote.host=127.0.0.1,remote.port=20004",
"tap,id=red,ifname=lt0,script=no,downscript=no",
"tap,id=blue,ifname=lt2,script=no,downscript=no",
}
wantDevices := []string{
"virtio-net-pci,netdev=mgmt0,mac=02:4d:00:00:00:00,romfile=",
"virtio-net-pci,netdev=red,mac=02:4c:00:00:00:00,host_mtu=9000,romfile=",
"virtio-net-pci,netdev=blue,mac=02:4c:00:00:01:00,host_mtu=1500,romfile=",
}
if got := value(t, sw.QEMU, "-netdev"); !reflect.DeepEqual(got, wantNetdevs) {
t.Errorf("netdevs = %v\nwant %v", got, wantNetdevs)
}
if !hasValue(sw.QEMU, "-device", "virtio-net-pci,netdev=p2,mac=02:4c:00:03:00:01,host_mtu=9000,romfile=") {
t.Errorf("p2 device missing: %v", sw.QEMU)
if got := value(t, sw.QEMU, "-device"); !reflect.DeepEqual(got, wantDevices) {
t.Errorf("devices = %v\nwant %v", got, wantDevices)
}
}
func TestQEMU_OnlyTheSwitchReachesTheOutsideThroughAdministration(t *testing.T) {
for name, n := range renderAll(t, twoHypervisors) {
func TestQEMU_OnlyRoutersReachTheOutsideThroughAdministration(t *testing.T) {
for name, n := range renderAll(t, withVRRP) {
admin := value(t, n.QEMU, "-netdev")[0]
wantRestrict := "restrict=on"
if name == "sw1" {
if name == "r1" || name == "r2" || name == "r3" {
wantRestrict = "restrict=off"
}
if !strings.Contains(admin, ","+wantRestrict+",") {
@ -228,33 +250,28 @@ func TestQEMU_OnlyTheSwitchReachesTheOutsideThroughAdministration(t *testing.T)
}
}
func TestQEMU_EveryCableEndsMatch(t *testing.T) {
ends := map[string]int{}
for _, n := range renderAll(t, twoHypervisors) {
func TestQEMU_EveryTapOfThePlanIsOpenedOnce(t *testing.T) {
p := plan(t, withVRRP)
opened := map[string]int{}
for _, n := range renderAll(t, withVRRP) {
for _, nd := range value(t, n.QEMU, "-netdev") {
if !strings.HasPrefix(nd, "dgram,") {
continue
if strings.HasPrefix(nd, "dgram") || strings.HasPrefix(nd, "socket") {
t.Errorf("%s uses a %s netdev", n.Name, nd)
}
var local, remote string
for _, kv := range strings.Split(nd, ",") {
if v, ok := strings.CutPrefix(kv, "local.port="); ok {
local = v
}
if v, ok := strings.CutPrefix(kv, "remote.port="); ok {
remote = v
if tap, ok := strings.CutPrefix(kv, "ifname="); ok {
opened[tap]++
}
}
ends[local+">"+remote]++
}
}
for pair, count := range ends {
local, remote, _ := strings.Cut(pair, ">")
if count != 1 || ends[remote+">"+local] != 1 {
t.Errorf("cable end %s has no single matching end", pair)
}
if len(opened) != len(p.Ports) {
t.Errorf("%d taps opened, plan has %d ports", len(opened), len(p.Ports))
}
if len(ends) != 6 {
t.Errorf("%d cable ends, want 6", len(ends))
for _, port := range p.Ports {
if opened[port.Tap] != 1 {
t.Errorf("tap %s opened %d times", port.Tap, opened[port.Tap])
}
}
}
@ -270,7 +287,7 @@ func TestNetworkConfig_Hypervisor(t *testing.T) {
}
under := iface(t, doc, "underlay")
if under.Match.MACAddress != "02:4c:00:02:00:00" || under.SetName != "underlay" || under.MTU != 9000 ||
!reflect.DeepEqual(under.Addresses, []string{"10.250.0.3/24"}) {
!reflect.DeepEqual(under.Addresses, []string{"10.250.0.4/24"}) {
t.Errorf("underlay = %+v", under)
}
if !reflect.DeepEqual(under.Routes, []route{{To: "0.0.0.0/0", Via: "10.250.0.1"}}) {
@ -289,17 +306,27 @@ func TestNetworkConfig_DHCPIsExplicitlyOffEverywhere(t *testing.T) {
}
}
func TestNetworkConfig_Switch(t *testing.T) {
doc := network(t, nodeNamed(t, renderAll(t, twoHypervisors), "sw1"))
func TestNetworkConfig_Router(t *testing.T) {
doc := network(t, nodeNamed(t, renderAll(t, twoSegments), "sw"))
if len(doc.Ethernets) != 3 {
t.Fatalf("network-config = %+v", doc)
}
admin := iface(t, doc, "mgmt0")
if !reflect.DeepEqual(admin.Routes, []route{{To: "0.0.0.0/0", Via: "10.0.2.2"}}) ||
admin.Nameservers == nil || !reflect.DeepEqual(admin.Nameservers.Addresses, []string{"10.0.2.3"}) {
t.Errorf("switch mgmt0 = %+v", admin)
t.Errorf("router mgmt0 = %+v", admin)
}
for port, mac := range map[string]string{"p0": "02:4c:00:01:00:01", "p1": "02:4c:00:02:00:01", "p2": "02:4c:00:03:00:01"} {
e := iface(t, doc, port)
if e.Match.MACAddress != mac || e.SetName != port || e.MTU != 9000 || len(e.Addresses) != 0 || len(e.Routes) != 0 {
t.Errorf("%s = %+v", port, e)
for name, want := range map[string]struct {
mac, address string
mtu int
}{
"red": {"02:4c:00:00:00:00", "10.1.0.2/24", 9000},
"blue": {"02:4c:00:00:01:00", "10.2.0.2/24", 1500},
} {
e := iface(t, doc, name)
if e.Match.MACAddress != want.mac || e.SetName != name || e.MTU != want.mtu ||
!reflect.DeepEqual(e.Addresses, []string{want.address}) || len(e.Routes) != 0 || e.Nameservers != nil {
t.Errorf("%s = %+v", name, e)
}
}
}
@ -333,45 +360,71 @@ func TestUserData_PasswordLoginIsExplicitlyOff(t *testing.T) {
}
}
func TestUserData_SwitchBuildsBridgeGatewayAndNAT(t *testing.T) {
func TestNetworkConfig_DefaultRouteOnTheFirstSegmentWithAGateway(t *testing.T) {
doc := network(t, nodeNamed(t, renderAll(t, withVRRP), "hv"))
pure, red := iface(t, doc, "pure"), iface(t, doc, "red")
if len(pure.Routes) != 0 || pure.Nameservers != nil || !reflect.DeepEqual(pure.Addresses, []string{"10.3.0.3/24"}) {
t.Errorf("pure = %+v", pure)
}
if !reflect.DeepEqual(red.Routes, []route{{To: "0.0.0.0/0", Via: "10.1.0.1"}}) || red.Nameservers == nil ||
!reflect.DeepEqual(red.Addresses, []string{"10.1.0.4/24"}) {
t.Errorf("red = %+v", red)
}
}
func TestNetworkConfig_NoDefaultRouteWithoutGateway(t *testing.T) {
for name, e := range network(t, nodeNamed(t, renderAll(t, withVRRP), "l2")).Ethernets {
if len(e.Routes) != 0 || e.Nameservers != nil {
t.Errorf("%s = %+v, want no route", name, e)
}
}
}
func TestNetworkConfig_RouterHasNoDefaultRouteOnItsSegments(t *testing.T) {
doc := network(t, nodeNamed(t, renderAll(t, withVRRP), "r1"))
for _, name := range []string{"red", "blue"} {
if e := iface(t, doc, name); len(e.Routes) != 0 || e.Nameservers != nil {
t.Errorf("%s = %+v", name, e)
}
}
if admin := iface(t, doc, "mgmt0"); len(admin.Routes) != 1 {
t.Errorf("mgmt0 = %+v", admin)
}
}
func TestUserData_RouterBuildsGatewayAndNAT(t *testing.T) {
cfg := user(t, nodeNamed(t, renderAll(t, twoHypervisors), "sw1"))
if !reflect.DeepEqual(cfg.Packages, []string{"nftables"}) {
t.Errorf("packages = %v", cfg.Packages)
}
script := fileAt(t, cfg, "/usr/local/sbin/lab-switch")
script := fileAt(t, cfg, "/usr/local/sbin/lab-router")
if script.Permissions != "0755" {
t.Errorf("script permissions = %s", script.Permissions)
}
wantScript := `#!/bin/sh
set -eu
sysctl -qw net.ipv4.ip_forward=1
ip link add br-underlay type bridge stp_state 0 2>/dev/null || true
ip link set dev p0 master br-underlay
ip link set dev p0 up
ip link set dev p1 master br-underlay
ip link set dev p1 up
ip link set dev p2 master br-underlay
ip link set dev p2 up
ip link set dev br-underlay mtu 9000
ip addr replace 10.250.0.1/24 dev br-underlay
ip link set dev br-underlay up
nft -f /etc/lab-switch.nft
ip addr replace 10.250.0.1/24 dev underlay
nft -f /etc/lab-router.nft
`
if script.Content != wantScript {
t.Errorf("script:\n%s\nwant:\n%s", script.Content, wantScript)
}
nft := fileAt(t, cfg, "/etc/lab-switch.nft").Content
nftFile := fileAt(t, cfg, "/etc/lab-router.nft")
if nftFile.Permissions != "0644" {
t.Errorf("nft permissions = %s", nftFile.Permissions)
}
for _, want := range []string{
"add table ip lab_nat\ndelete table ip lab_nat\n",
"type nat hook postrouting priority srcnat;",
`ip saddr { 10.250.0.0/24 } oifname "mgmt0" masquerade`,
} {
if !strings.Contains(nft, want) {
t.Errorf("nft rules miss %q:\n%s", want, nft)
if !strings.Contains(nftFile.Content, want) {
t.Errorf("nft rules miss %q:\n%s", want, nftFile.Content)
}
}
unit := fileAt(t, cfg, "/etc/systemd/system/lab-switch.service").Content
for _, want := range []string{"Type=oneshot", "RemainAfterExit=yes", "ExecStart=/usr/local/sbin/lab-switch", "After=network-online.target", "WantedBy=multi-user.target"} {
unit := fileAt(t, cfg, "/etc/systemd/system/lab-router.service").Content
for _, want := range []string{"Type=oneshot", "RemainAfterExit=yes", "ExecStart=/usr/local/sbin/lab-router", "After=network-online.target", "WantedBy=multi-user.target"} {
if !strings.Contains(unit, want) {
t.Errorf("unit misses %q", want)
}
@ -379,29 +432,82 @@ nft -f /etc/lab-switch.nft
if !reflect.DeepEqual(cfg.Runcmd, [][]string{{"/usr/local/sbin/lab-provision"}}) {
t.Errorf("runcmd = %v", cfg.Runcmd)
}
if got := fileAt(t, cfg, "/usr/local/sbin/lab-provision").Content; got != "#!/bin/sh\nset -eu\nsystemctl daemon-reload\nsystemctl enable --now lab-switch.service\n" {
if got := fileAt(t, cfg, "/usr/local/sbin/lab-provision").Content; got != "#!/bin/sh\nset -eu\nsystemctl daemon-reload\nsystemctl enable --now lab-router.service\n" {
t.Errorf("lab-provision:\n%s", got)
}
}
func TestUserData_SwitchWithTwoSegments(t *testing.T) {
func TestUserData_RouterWithTwoSegments(t *testing.T) {
cfg := user(t, nodeNamed(t, renderAll(t, twoSegments), "sw"))
script := fileAt(t, cfg, "/usr/local/sbin/lab-switch").Content
for _, want := range []string{
"ip link set dev p0 master br-red\n",
"ip link set dev p1 master br-blue\n",
"ip link set dev br-blue mtu 1500\n",
"ip addr replace 10.2.0.1/24 dev br-blue\n",
script := fileAt(t, cfg, "/usr/local/sbin/lab-router").Content
want := "sysctl -qw net.ipv4.ip_forward=1\nip addr replace 10.1.0.1/24 dev red\nip addr replace 10.2.0.1/24 dev blue\nnft -f /etc/lab-router.nft\n"
if !strings.HasSuffix(script, want) {
t.Errorf("script:\n%s\ndoes not end with:\n%s", script, want)
}
if nft := fileAt(t, cfg, "/etc/lab-router.nft").Content; !strings.Contains(nft, "ip saddr { 10.1.0.0/24, 10.2.0.0/24 }") {
t.Errorf("nft:\n%s", nft)
}
}
func TestUserData_RouterScriptWithVRRPAndSingleSegments(t *testing.T) {
script := fileAt(t, user(t, nodeNamed(t, renderAll(t, withVRRP), "r1")), "/usr/local/sbin/lab-router").Content
want := `#!/bin/sh
set -eu
sysctl -qw net.ipv4.ip_forward=1
sysctl -qw net.ipv4.conf.red.arp_ignore=1 net.ipv4.conf.red.arp_announce=2
ip link show dev vrred >/dev/null 2>&1 || { ip link add vrred link red type macvlan mode bridge && ip link set dev vrred protodown on; }
ip link set dev vrred addrgenmode random address 00:00:5e:00:01:01
ip addr replace 10.1.0.1/24 dev vrred
ip link set dev vrred up
ip addr replace 10.2.0.1/24 dev blue
nft -f /etc/lab-router.nft
`
if script != want {
t.Errorf("script:\n%s\nwant:\n%s", script, want)
}
r2 := fileAt(t, user(t, nodeNamed(t, renderAll(t, withVRRP), "r2")), "/usr/local/sbin/lab-router").Content
if !strings.Contains(r2, "ip addr replace 10.1.0.1/24 dev vrred\n") || strings.Contains(r2, "dev pure") {
t.Errorf("r2 script:\n%s", r2)
}
}
func TestUserData_RouterNATCoversTheSegmentsItRoutes(t *testing.T) {
nodes := renderAll(t, withVRRP)
for name, want := range map[string]string{
"r1": "ip saddr { 10.1.0.0/24, 10.2.0.0/24 }",
"r2": "ip saddr { 10.1.0.0/24 }",
} {
if !strings.Contains(script, want) {
t.Errorf("script misses %q:\n%s", want, script)
if nft := fileAt(t, user(t, nodeNamed(t, nodes, name)), "/etc/lab-router.nft").Content; !strings.Contains(nft, want) {
t.Errorf("%s nft:\n%s\nmisses %s", name, nft, want)
}
}
if strings.Contains(script, "p1 master br-red") || strings.Contains(script, "p0 master br-blue") {
t.Errorf("port bridged on the wrong segment:\n%s", script)
cfg := user(t, nodeNamed(t, nodes, "r3"))
if nft := fileAt(t, cfg, "/etc/lab-router.nft").Content; nft != "add table ip lab_nat\ndelete table ip lab_nat\n" {
t.Errorf("r3 nft:\n%s", nft)
}
if nft := fileAt(t, cfg, "/etc/lab-switch.nft").Content; !strings.Contains(nft, "ip saddr { 10.1.0.0/24, 10.2.0.0/24 }") {
t.Errorf("nft:\n%s", nft)
if script := fileAt(t, cfg, "/usr/local/sbin/lab-router").Content; script != "#!/bin/sh\nset -eu\nsysctl -qw net.ipv4.ip_forward=1\nnft -f /etc/lab-router.nft\n" {
t.Errorf("r3 script:\n%s", script)
}
}
func TestVRRPMAC(t *testing.T) {
for vrid, want := range map[int]string{1: "00:00:5e:00:01:01", 16: "00:00:5e:00:01:10", 255: "00:00:5e:00:01:ff"} {
if got := vrrpMAC(vrid); got != want {
t.Errorf("vrrpMAC(%d) = %s, want %s", vrid, got, want)
}
}
}
func TestVRRPPriorityFollowsTheRoutersOrder(t *testing.T) {
var routers []string
for i := 0; i < 22; i++ {
routers = append(routers, "r"+strconv.Itoa(i))
}
s := topology.SegmentPlan{Routers: routers}
for name, want := range map[string]int{"r0": 200, "r1": 190, "r19": 10, "r20": 1, "r21": 1} {
if got := vrrpPriority(s, name); got != want {
t.Errorf("priority of %s = %d, want %d", name, got, want)
}
}
}
@ -415,7 +521,7 @@ func TestMetaData(t *testing.T) {
}
}
func TestRender_AdminMacsAreUniqueAndApartFromCableMacs(t *testing.T) {
func TestRender_AdminMacsAreUniqueAndApartFromPortMacs(t *testing.T) {
seen := map[string]string{}
for name, n := range renderAll(t, twoHypervisors) {
for _, d := range value(t, n.QEMU, "-device") {
@ -429,8 +535,8 @@ func TestRender_AdminMacsAreUniqueAndApartFromCableMacs(t *testing.T) {
}
}
}
if len(seen) != 10 {
t.Errorf("%d distinct macs, want 10", len(seen))
if len(seen) != 8 {
t.Errorf("%d distinct macs, want 8", len(seen))
}
}