labctl/internal/machine/machine_test.go
GnomeZworc e9a0c19b72
All checks were successful
Tests / test (push) Successful in 3m46s
labctl: segments sur des bridges de l'hôte, routeurs et passerelle VRRP #2
Signed-off-by: GnomeZworc <nicolas.boufidjeline@g3e.fr>
2026-10-13 09:57:09 +02:00

932 lines
26 KiB
Go

package machine
import (
"bytes"
"context"
"crypto/sha512"
"encoding/hex"
"errors"
"fmt"
"net/http"
"net/http/httptest"
"os"
"os/exec"
"path/filepath"
"reflect"
"strconv"
"strings"
"sync"
"syscall"
"testing"
"time"
"git.g3e.fr/syonad/labctl/internal/provision"
"git.g3e.fr/syonad/labctl/internal/topology"
)
const labKey = "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIFG/JMmjfko96WkJV8DiL6rip/H/q/R++y8s27Z+Cj6O labctl"
type exitErr int
func (e exitErr) Error() string { return "exit status " + strconv.Itoa(int(e)) }
func (e exitErr) ExitCode() int { return int(e) }
type fakeRunner struct {
mu sync.Mutex
calls [][]string
fail string
ssh map[string][]error
always map[string]error
inactive string
links map[string]bool
}
func (f *fakeRunner) Run(_ context.Context, name string, args ...string) error {
f.mu.Lock()
defer f.mu.Unlock()
f.calls = append(f.calls, append([]string{name}, args...))
if name == f.fail {
return errors.New(name + " failed")
}
switch name {
case "ssh-keygen":
private := args[len(args)-1]
if err := os.WriteFile(private, []byte("private"), 0o600); err != nil {
return err
}
return os.WriteFile(private+".pub", []byte(labKey+"\n"), 0o644)
case "ip":
if f.links == nil {
f.links = map[string]bool{}
}
switch {
case len(args) == 4 && args[0] == "link" && args[1] == "show":
if !f.links[args[3]] {
return exitErr(1)
}
case args[0] == "link" && args[1] == "add" && args[2] == "name":
f.links[args[3]] = true
case args[0] == "tuntap" && args[1] == "add":
f.links[args[3]] = true
case args[0] == "link" && args[1] == "delete":
delete(f.links, args[3])
}
case "ssh":
port := args[indexOf(args, "-p")+1]
if args[len(args)-1] == f.inactive {
return exitErr(3)
}
answers := f.ssh[port]
if len(answers) == 0 {
return f.always[port]
}
f.ssh[port] = answers[1:]
return answers[0]
}
return nil
}
func (f *fakeRunner) commands(name string) [][]string {
f.mu.Lock()
defer f.mu.Unlock()
var out [][]string
for _, c := range f.calls {
if c[0] == name {
out = append(out, c)
}
}
return out
}
func (f *fakeRunner) ipCalls() []string {
var out []string
for _, c := range f.commands("ip") {
out = append(out, strings.Join(c[1:], " "))
}
return out
}
func (f *fakeRunner) present(links ...string) {
f.mu.Lock()
defer f.mu.Unlock()
if f.links == nil {
f.links = map[string]bool{}
}
for _, l := range links {
f.links[l] = true
}
}
func indexOf(list []string, value string) int {
for i, v := range list {
if v == value {
return i
}
}
return -1
}
func mirror(t *testing.T) (*httptest.Server, string) {
t.Helper()
content := []byte("qcow2 image")
h := sha512.Sum512(content)
server := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if strings.HasSuffix(r.URL.Path, "SHA512SUMS") {
fmt.Fprintf(w, "%s deb.qcow2\n", hex.EncodeToString(h[:]))
return
}
w.Write(content)
}))
t.Cleanup(server.Close)
return server, server.URL
}
const underlay = ` underlay: { routers: [sw1], cidr: 10.250.0.0/24, mtu: 9000 }
`
func labPlan(t *testing.T, base, segments, nodes string) *topology.Plan {
t.Helper()
doc := `name: evpn-2hv
images:
deb:
url: ` + base + `/deb.qcow2
sums: ` + base + `/SHA512SUMS
segments:
` + segments + `nodes:
` + nodes
topo, err := topology.Parse([]byte(doc))
if err != nil {
t.Fatalf("Parse: %v", err)
}
p, err := topology.Compute(topo)
if err != nil {
t.Fatalf("Compute: %v", err)
}
return p
}
const routerLast = ` rr1: { role: rr, image: deb, cpus: 1, memory: 1024, segments: [underlay] }
hv1: { role: host, image: deb, cpus: 4, memory: 16384, segments: [underlay], services: [agent.service] }
sw1: { role: router, image: deb, cpus: 2, memory: 1024, segments: [underlay] }
`
const twoSegments = ` red: { routers: [r1, r2], cidr: 10.1.0.0/24 }
blue: { cidr: 10.2.0.0/24, mtu: 1500 }
`
const twoRouters = ` r1: { role: router, image: deb, cpus: 1, memory: 512, segments: [red] }
r2: { role: router, image: deb, cpus: 1, memory: 512, segments: [red] }
hv: { role: host, image: deb, cpus: 1, memory: 512, segments: [red, blue] }
`
type fixture struct {
lab Lab
runner *fakeRunner
out *bytes.Buffer
fetcher provision.Fetcher
}
func newFixture(t *testing.T, nodes string) *fixture {
t.Helper()
return newLab(t, underlay, nodes)
}
func newLab(t *testing.T, segments, nodes string) *fixture {
t.Helper()
server, base := mirror(t)
root := t.TempDir()
runner := &fakeRunner{ssh: map[string][]error{}, always: map[string]error{}}
out := &bytes.Buffer{}
return &fixture{
lab: Lab{
Plan: labPlan(t, base, segments, nodes),
RunDir: filepath.Join(root, "run"),
ProcDir: filepath.Join(root, "proc"),
Runner: runner,
Poll: time.Millisecond,
Stop: 500 * time.Millisecond,
Out: out,
},
runner: runner,
out: out,
fetcher: provision.Fetcher{Client: server.Client(), CacheDir: filepath.Join(root, "cache")},
}
}
func (f *fixture) process(t *testing.T, node, script string, cmdline ...string) int {
t.Helper()
cmd := exec.Command("sh", "-c", script)
if err := cmd.Start(); err != nil {
t.Fatal(err)
}
done := make(chan struct{})
go func() { cmd.Wait(); close(done) }()
t.Cleanup(func() {
cmd.Process.Kill()
<-done
})
pid := cmd.Process.Pid
proc := filepath.Join(f.lab.ProcDir, strconv.Itoa(pid))
if err := os.MkdirAll(proc, 0o755); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(filepath.Join(proc, "cmdline"), []byte(strings.Join(cmdline, "\x00")+"\x00"), 0o644); err != nil {
t.Fatal(err)
}
f.pidFile(t, node, strconv.Itoa(pid)+"\n")
return pid
}
func (f *fixture) pidFile(t *testing.T, node, content string) {
t.Helper()
dir := filepath.Join(f.lab.RunDir, node)
if err := os.MkdirAll(dir, 0o700); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(filepath.Join(dir, "qemu.pid"), []byte(content), 0o600); err != nil {
t.Fatal(err)
}
}
func qemu(node string) []string {
return []string{"qemu-system-x86_64", "-name", node, "-machine", "q35"}
}
func alive(pid int) bool {
err := syscall.Kill(pid, 0)
return err == nil || errors.Is(err, syscall.EPERM)
}
func waitDead(t *testing.T, pid int) {
t.Helper()
deadline := time.Now().Add(2 * time.Second)
for alive(pid) && time.Now().Before(deadline) {
time.Sleep(5 * time.Millisecond)
}
if alive(pid) {
t.Errorf("pid %d is still alive", pid)
}
}
func TestPID_NoPidFileMeansStopped(t *testing.T) {
f := newFixture(t, routerLast)
if pid, err := f.lab.PID("hv1"); pid != 0 || err != nil {
t.Errorf("PID = %d, %v", pid, err)
}
}
func TestPID_RefusesACorruptedPidFile(t *testing.T) {
for _, content := range []string{"", "abc", "0", "-12"} {
f := newFixture(t, routerLast)
f.pidFile(t, "hv1", content)
if _, err := f.lab.PID("hv1"); err == nil || !strings.Contains(err.Error(), "not a pid") {
t.Errorf("pid file %q: error = %v", content, err)
}
}
}
func TestPID_RecognisesTheNodeProcess(t *testing.T) {
f := newFixture(t, routerLast)
want := f.process(t, "hv1", "sleep 30", qemu("hv1")...)
if pid, err := f.lab.PID("hv1"); pid != want || err != nil {
t.Errorf("PID = %d, %v, want %d", pid, err, want)
}
}
func TestPID_IgnoresAPidReusedByAnotherProcess(t *testing.T) {
cases := map[string][]string{
"another program": {"/usr/sbin/sshd", "-D"},
"another node": qemu("hv10"),
"name as a value": {"qemu-system-x86_64", "-serial", "-name", "-name", "hv2"},
}
for name, cmdline := range cases {
t.Run(name, func(t *testing.T) {
f := newFixture(t, routerLast)
f.process(t, "hv1", "sleep 30", cmdline...)
if pid, err := f.lab.PID("hv1"); pid != 0 || err != nil {
t.Errorf("PID = %d, %v, want 0", pid, err)
}
})
}
}
func TestPID_IgnoresADeadProcess(t *testing.T) {
f := newFixture(t, routerLast)
pid := f.process(t, "hv1", "exit 0", qemu("hv1")...)
waitDead(t, pid)
if got, err := f.lab.PID("hv1"); got != 0 || err != nil {
t.Errorf("PID = %d, %v, want 0", got, err)
}
}
func TestStatus(t *testing.T) {
f := newFixture(t, routerLast)
pid := strconv.Itoa(f.process(t, "hv1", "sleep 30", qemu("hv1")...))
var out bytes.Buffer
if err := f.lab.Status(&out); err != nil {
t.Fatal(err)
}
w := len(pid)
if w < 3 {
w = 3
}
want := fmt.Sprintf("node role state %-*s ssh\n", w, "pid") +
fmt.Sprintf("rr1 rr stopped %-*s 127.0.0.1:2200\n", w, "-") +
fmt.Sprintf("hv1 host running %-*s 127.0.0.1:2201\n", w, pid) +
fmt.Sprintf("sw1 router stopped %-*s 127.0.0.1:2202\n", w, "-") +
"\nsegment bridge state gateway\n" +
"underlay lb-underlay absent 10.250.0.1\n"
if out.String() != want {
t.Errorf("status:\n%s\nwant:\n%s", out.String(), want)
}
}
func TestDown_StopsWithSIGTERM(t *testing.T) {
f := newFixture(t, routerLast)
pid := f.process(t, "hv1", "sleep 30", qemu("hv1")...)
if err := f.lab.Down(context.Background()); err != nil {
t.Fatalf("Down: %v", err)
}
waitDead(t, pid)
if _, err := os.Stat(filepath.Join(f.lab.RunDir, "hv1", "qemu.pid")); !os.IsNotExist(err) {
t.Errorf("pid file still there: %v", err)
}
if f.out.String() != "hv1: stopped\n" {
t.Errorf("output = %q", f.out.String())
}
}
func TestDown_FallsBackToSIGKILL(t *testing.T) {
f := newFixture(t, routerLast)
f.lab.Stop = 100 * time.Millisecond
pid := f.process(t, "hv1", `trap "" TERM; while :; do sleep 0.05; done`, qemu("hv1")...)
time.Sleep(50 * time.Millisecond)
start := time.Now()
if err := f.lab.Down(context.Background()); err != nil {
t.Fatalf("Down: %v", err)
}
waitDead(t, pid)
if elapsed := time.Since(start); elapsed < 100*time.Millisecond {
t.Errorf("SIGKILL after %v, want at least the 100ms grace period", elapsed)
}
}
func TestDown_NeverSignalsAProcessThatIsNotTheNode(t *testing.T) {
f := newFixture(t, routerLast)
pid := f.process(t, "hv1", "sleep 30", "/usr/sbin/sshd", "-D")
if err := f.lab.Down(context.Background()); err != nil {
t.Fatalf("Down: %v", err)
}
time.Sleep(50 * time.Millisecond)
if !alive(pid) {
t.Error("a process that is not the node was killed")
}
if f.out.Len() != 0 {
t.Errorf("output = %q", f.out.String())
}
}
func TestDown_ReportsACorruptedPidFileAndStopsTheOthers(t *testing.T) {
f := newFixture(t, routerLast)
f.pidFile(t, "rr1", "garbage")
pid := f.process(t, "hv1", "sleep 30", qemu("hv1")...)
err := f.lab.Down(context.Background())
if err == nil || !strings.Contains(err.Error(), "not a pid") {
t.Errorf("error = %v", err)
}
waitDead(t, pid)
}
func TestSSH_Arguments(t *testing.T) {
f := newFixture(t, routerLast)
key := filepath.Join(f.lab.RunDir, "lab_ed25519")
base := []string{
"-i", key,
"-o", "IdentitiesOnly=yes",
"-o", "IdentityAgent=none",
"-o", "StrictHostKeyChecking=no",
"-o", "UserKnownHostsFile=/dev/null",
"-o", "LogLevel=ERROR",
"-p", "2201",
"debian@127.0.0.1",
}
cases := map[string]struct {
terminal bool
command []string
want []string
}{
"interactive shell": {true, nil, append([]string{"ssh"}, base...)},
"command from a terminal": {true, []string{"top"}, append(append([]string{"ssh", "-t"}, base...), "top")},
"command from a script": {false, []string{"ip", "-br", "a"}, append(append([]string{"ssh"}, base...), "ip", "-br", "a")},
"shell from a script": {false, nil, append([]string{"ssh"}, base...)},
}
for name, c := range cases {
t.Run(name, func(t *testing.T) {
got, err := f.lab.SSH("hv1", c.terminal, c.command)
if err != nil {
t.Fatal(err)
}
if !reflect.DeepEqual(got, c.want) {
t.Errorf("\n got %q\nwant %q", got, c.want)
}
})
}
}
func TestSSH_UnknownNode(t *testing.T) {
f := newFixture(t, routerLast)
if _, err := f.lab.SSH("hv9", true, nil); err == nil || !strings.Contains(err.Error(), `node "hv9" is not in lab evpn-2hv`) {
t.Errorf("error = %v", err)
}
}
func TestUp_StartsRoutersFirstAndWaitsForEveryNode(t *testing.T) {
f := newFixture(t, routerLast)
if err := f.lab.Up(context.Background(), f.fetcher, time.Second); err != nil {
t.Fatalf("Up: %v", err)
}
var started []string
for _, c := range f.runner.commands("qemu-system-x86_64") {
if c[len(c)-1] != "-daemonize" {
t.Errorf("qemu not daemonized: %q", c)
}
started = append(started, c[indexOf(c, "-name")+1])
}
if !reflect.DeepEqual(started, []string{"sw1", "rr1", "hv1"}) {
t.Errorf("start order = %v, want the router first", started)
}
ssh := f.runner.commands("ssh")
if len(ssh) != 4 {
t.Fatalf("%d ssh calls, want 4", len(ssh))
}
want := []string{"ssh",
"-i", filepath.Join(f.lab.RunDir, "lab_ed25519"),
"-o", "IdentitiesOnly=yes",
"-o", "IdentityAgent=none",
"-o", "StrictHostKeyChecking=no",
"-o", "UserKnownHostsFile=/dev/null",
"-o", "LogLevel=ERROR",
"-p", "2200",
"-o", "BatchMode=yes",
"-o", "ConnectTimeout=5",
"debian@127.0.0.1",
"cloud-init", "status", "--wait",
}
if !reflect.DeepEqual(ssh[0], want) {
t.Errorf("readiness check:\n got %q\nwant %q", ssh[0], want)
}
if f.out.String() != "sw1: started\nrr1: started\nhv1: started\nrr1: ready\nhv1: ready\nsw1: ready\n" {
t.Errorf("output = %q", f.out.String())
}
}
func TestUp_RetriesWhileSSHIsUnreachable(t *testing.T) {
f := newFixture(t, routerLast)
f.runner.ssh["2201"] = []error{exitErr(255), exitErr(255), nil}
if err := f.lab.Up(context.Background(), f.fetcher, time.Second); err != nil {
t.Fatalf("Up: %v", err)
}
if n := len(f.runner.commands("ssh")); n != 6 {
t.Errorf("%d ssh calls, want 6", n)
}
}
func TestUp_ReadinessFailures(t *testing.T) {
cases := map[string]struct {
answers []error
want string
}{
"cloud-init error": {[]error{exitErr(1)}, "node hv1: cloud-init failed: exit status 1"},
"not an exit status": {[]error{errors.New("fork failed")}, "node hv1: cloud-init failed: fork failed"},
"ssh never reachable": {nil, "node hv1: not reachable over ssh: context deadline exceeded"},
}
for name, c := range cases {
t.Run(name, func(t *testing.T) {
f := newFixture(t, routerLast)
f.lab.Poll = 10 * time.Millisecond
f.runner.ssh["2201"] = c.answers
f.runner.always["2201"] = exitErr(255)
err := f.lab.Up(context.Background(), f.fetcher, 300*time.Millisecond)
if err == nil || err.Error() != c.want {
t.Errorf("error = %v, want %q", err, c.want)
}
if !strings.Contains(f.out.String(), "rr1: ready\n") || !strings.Contains(f.out.String(), "sw1: ready\n") {
t.Errorf("the other nodes were not waited for: %q", f.out.String())
}
})
}
}
func TestUp_RecoverableCloudInitErrorsAreReportedNotFatal(t *testing.T) {
f := newFixture(t, routerLast)
f.runner.ssh["2201"] = []error{exitErr(2)}
if err := f.lab.Up(context.Background(), f.fetcher, time.Second); err != nil {
t.Fatalf("Up: %v", err)
}
if !strings.Contains(f.out.String(), "hv1: cloud-init finished with recoverable errors: exit status 2\nhv1: ready\n") {
t.Errorf("output = %q", f.out.String())
}
}
func TestUp_RefusesARunningLab(t *testing.T) {
f := newFixture(t, routerLast)
f.process(t, "hv1", "sleep 30", qemu("hv1")...)
err := f.lab.Up(context.Background(), f.fetcher, time.Second)
if err == nil || err.Error() != "lab evpn-2hv is already running (hv1): 'lab down' first" {
t.Errorf("error = %v", err)
}
if len(f.runner.calls) != 0 {
t.Errorf("commands ran: %q", f.runner.calls)
}
}
func TestUp_RemovesAStalePidFileBeforeStarting(t *testing.T) {
f := newFixture(t, routerLast)
pid := f.process(t, "hv1", "exit 0", qemu("hv1")...)
waitDead(t, pid)
if err := f.lab.Up(context.Background(), f.fetcher, time.Second); err != nil {
t.Fatalf("Up: %v", err)
}
if _, err := os.Stat(filepath.Join(f.lab.RunDir, "hv1", "qemu.pid")); !os.IsNotExist(err) {
t.Errorf("stale pid file kept: %v", err)
}
}
func TestUp_StopsAtTheFirstQEMUFailure(t *testing.T) {
f := newFixture(t, routerLast)
f.runner.fail = "qemu-system-x86_64"
err := f.lab.Up(context.Background(), f.fetcher, time.Second)
if err == nil || err.Error() != "node sw1: qemu-system-x86_64 failed" {
t.Errorf("error = %v", err)
}
if n := len(f.runner.commands("qemu-system-x86_64")); n != 1 {
t.Errorf("%d qemu starts, want 1", n)
}
if n := len(f.runner.commands("ssh")); n != 0 {
t.Errorf("%d ssh calls after a failed start", n)
}
}
func TestStop_RefusesPidsThatTargetAGroup(t *testing.T) {
f := newFixture(t, routerLast)
f.lab.signal = func(pid int, sig syscall.Signal) error {
t.Fatalf("signal %v sent to pid %d", sig, pid)
return nil
}
for _, pid := range []int{0, -1} {
if err := f.lab.stop(context.Background(), "hv1", pid); err == nil || err.Error() != fmt.Sprintf("refusing to signal pid %d", pid) {
t.Errorf("pid %d: error = %v", pid, err)
}
}
}
func TestUp_ChecksTheServicesOfEachRole(t *testing.T) {
f := newFixture(t, routerLast)
conf := filepath.Join(t.TempDir(), "sw1.conf")
if err := os.WriteFile(conf, []byte("hostname sw1\n"), 0o600); err != nil {
t.Fatal(err)
}
f.lab.Plan.Nodes[2].FRR = conf
if err := f.lab.Up(context.Background(), f.fetcher, time.Second); err != nil {
t.Fatalf("Up: %v", err)
}
var checks []string
for _, c := range f.runner.commands("ssh") {
if c[len(c)-4] == "systemctl" {
checks = append(checks, c[indexOf(c, "-p")+1]+" "+strings.Join(c[len(c)-4:], " "))
}
}
want := []string{
"2201 systemctl is-active --quiet agent.service",
"2202 systemctl is-active --quiet frr.service",
}
if !reflect.DeepEqual(checks, want) {
t.Errorf("checks = %q, want %q", checks, want)
}
}
func TestUp_ReportsAnInactiveServiceAndWaitsForTheOthers(t *testing.T) {
f := newFixture(t, routerLast)
f.runner.inactive = "agent.service"
err := f.lab.Up(context.Background(), f.fetcher, time.Second)
if err == nil || err.Error() != "node hv1: agent.service is not active: exit status 3" {
t.Errorf("error = %v", err)
}
if !strings.Contains(f.out.String(), "rr1: ready\n") || !strings.Contains(f.out.String(), "sw1: ready\n") || strings.Contains(f.out.String(), "hv1: ready") {
t.Errorf("output = %q", f.out.String())
}
}
func TestStatus_ShowsTheSegments(t *testing.T) {
f := newLab(t, twoSegments, twoRouters)
f.runner.present("lb-red")
var out bytes.Buffer
if err := f.lab.Status(&out); err != nil {
t.Fatal(err)
}
want := "\nsegment bridge state gateway\n" +
"red lb-red present 10.1.0.1\n" +
"blue lb-blue absent -\n"
if !strings.HasSuffix(out.String(), want) {
t.Errorf("status:\n%s\ndoes not end with:\n%s", out.String(), want)
}
}
func TestNetworkUp_CreatesBridgesAndTaps(t *testing.T) {
f := newLab(t, twoSegments, twoRouters)
if err := f.lab.NetworkUp(context.Background()); err != nil {
t.Fatalf("NetworkUp: %v", err)
}
want := []string{
"link show dev lb-red",
"link show dev lb-blue",
"link show dev lt0",
"link show dev lt1",
"link show dev lt2",
"link show dev lt3",
"link add name lb-red type bridge stp_state 0 mcast_snooping 0",
"link set dev lb-red addrgenmode none",
"tuntap add dev lt0 mode tap",
"link set dev lt0 addrgenmode none",
"link set dev lt0 mtu 9000 master lb-red up",
"tuntap add dev lt1 mode tap",
"link set dev lt1 addrgenmode none",
"link set dev lt1 mtu 9000 master lb-red up",
"tuntap add dev lt2 mode tap",
"link set dev lt2 addrgenmode none",
"link set dev lt2 mtu 9000 master lb-red up",
"link set dev lb-red mtu 9000 up",
"link add name lb-blue type bridge stp_state 0 mcast_snooping 0",
"link set dev lb-blue addrgenmode none",
"tuntap add dev lt3 mode tap",
"link set dev lt3 addrgenmode none",
"link set dev lt3 mtu 1500 master lb-blue up",
"link set dev lb-blue mtu 1500 up",
}
if got := f.runner.ipCalls(); !reflect.DeepEqual(got, want) {
t.Errorf("ip calls:\n%s\nwant:\n%s", strings.Join(got, "\n"), strings.Join(want, "\n"))
}
if len(f.runner.calls) != len(want) {
t.Errorf("other commands ran: %q", f.runner.calls)
}
}
func TestNetworkUp_RefusesExistingLinks(t *testing.T) {
cases := map[string]struct {
link, want string
}{
"bridge": {"lb-blue", "segment blue: bridge lb-blue already exists on this host: 'labctl down' first, or remove it"},
"tap": {"lt2", "node hv: tap lt2 already exists on this host: 'labctl down' first, or remove it"},
}
for name, c := range cases {
t.Run(name, func(t *testing.T) {
f := newLab(t, twoSegments, twoRouters)
f.runner.present(c.link)
dir := filepath.Join(f.lab.ProcDir, "sys", "net", "bridge")
if err := os.MkdirAll(dir, 0o755); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(filepath.Join(dir, "bridge-nf-call-iptables"), []byte("1\n"), 0o644); err != nil {
t.Fatal(err)
}
err := f.lab.NetworkUp(context.Background())
if err == nil || err.Error() != c.want {
t.Errorf("error = %v, want %q", err, c.want)
}
for _, call := range f.runner.ipCalls() {
if !strings.HasPrefix(call, "link show dev ") {
t.Errorf("%q ran after the refusal", call)
}
}
if data, _ := os.ReadFile(filepath.Join(dir, "bridge-nf-call-iptables")); string(data) != "1\n" {
t.Errorf("bridge filter changed to %q", data)
}
})
}
}
func TestNetworkUp_DisablesTheBridgeFilterWhenPresent(t *testing.T) {
f := newLab(t, twoSegments, twoRouters)
dir := filepath.Join(f.lab.ProcDir, "sys", "net", "bridge")
if err := os.MkdirAll(dir, 0o755); err != nil {
t.Fatal(err)
}
path := filepath.Join(dir, "bridge-nf-call-iptables")
if err := os.WriteFile(path, []byte("1\n"), 0o644); err != nil {
t.Fatal(err)
}
if err := f.lab.NetworkUp(context.Background()); err != nil {
t.Fatalf("NetworkUp: %v", err)
}
if data, err := os.ReadFile(path); err != nil || string(data) != "0\n" {
t.Errorf("bridge filter = %q, %v, want 0", data, err)
}
}
func TestNetworkUp_LeavesAnAbsentBridgeFilterAlone(t *testing.T) {
f := newLab(t, twoSegments, twoRouters)
if err := f.lab.NetworkUp(context.Background()); err != nil {
t.Fatalf("NetworkUp: %v", err)
}
if _, err := os.Stat(filepath.Join(f.lab.ProcDir, "sys")); !os.IsNotExist(err) {
t.Errorf("bridge filter created under the proc dir: %v", err)
}
}
func TestNetworkUp_ReportsTheFailingSegment(t *testing.T) {
f := newLab(t, twoSegments, twoRouters)
f.runner.fail = "ip"
err := f.lab.NetworkUp(context.Background())
if err == nil || err.Error() != "segment red: ip failed" {
t.Errorf("error = %v", err)
}
}
func TestNetworkDown_DeletesTapsThenBridgesThatExist(t *testing.T) {
f := newLab(t, twoSegments, twoRouters)
f.runner.present("lb-red", "lb-blue", "lt0", "lt2", "lt3")
if err := f.lab.NetworkDown(context.Background()); err != nil {
t.Fatalf("NetworkDown: %v", err)
}
var deleted []string
for _, call := range f.runner.ipCalls() {
if link, ok := strings.CutPrefix(call, "link delete dev "); ok {
deleted = append(deleted, link)
}
}
if want := []string{"lt0", "lt2", "lt3", "lb-red", "lb-blue"}; !reflect.DeepEqual(deleted, want) {
t.Errorf("deleted %v, want %v", deleted, want)
}
if len(f.runner.links) != 0 {
t.Errorf("links left: %v", f.runner.links)
}
}
func TestDown_RemovesTheNetworkAfterTheNodes(t *testing.T) {
f := newFixture(t, routerLast)
f.runner.present("lb-underlay", "lt0", "lt1", "lt2")
f.process(t, "hv1", "sleep 30", qemu("hv1")...)
if err := f.lab.Down(context.Background()); err != nil {
t.Fatalf("Down: %v", err)
}
var deleted []string
for _, call := range f.runner.ipCalls() {
if link, ok := strings.CutPrefix(call, "link delete dev "); ok {
deleted = append(deleted, link)
}
}
if want := []string{"lt0", "lt1", "lt2", "lb-underlay"}; !reflect.DeepEqual(deleted, want) {
t.Errorf("deleted %v, want %v", deleted, want)
}
if f.out.String() != "hv1: stopped\n" {
t.Errorf("output = %q", f.out.String())
}
}
func TestDown_KeepsTheNetworkWhenANodeCannotBeStopped(t *testing.T) {
f := newFixture(t, routerLast)
f.runner.present("lb-underlay", "lt0", "lt1", "lt2")
f.pidFile(t, "rr1", "garbage")
if err := f.lab.Down(context.Background()); err == nil {
t.Fatal("Down succeeded")
}
if calls := f.runner.ipCalls(); len(calls) != 0 {
t.Errorf("ip calls after a failed stop: %q", calls)
}
}
func TestUp_BuildsTheNetworkBeforeStartingQEMU(t *testing.T) {
f := newLab(t, twoSegments, twoRouters)
if err := f.lab.Up(context.Background(), f.fetcher, time.Second); err != nil {
t.Fatalf("Up: %v", err)
}
lastIP, firstQEMU := -1, -1
var started []string
for i, c := range f.runner.calls {
switch c[0] {
case "ip":
lastIP = i
case "qemu-system-x86_64":
if firstQEMU < 0 {
firstQEMU = i
}
started = append(started, c[indexOf(c, "-name")+1])
}
}
if lastIP < 0 || firstQEMU < 0 || lastIP > firstQEMU {
t.Errorf("last ip call at %d, first qemu start at %d", lastIP, firstQEMU)
}
if !reflect.DeepEqual(started, []string{"r1", "r2", "hv"}) {
t.Errorf("start order = %v", started)
}
for _, link := range []string{"lb-red", "lb-blue", "lt0", "lt1", "lt2", "lt3"} {
if !f.runner.links[link] {
t.Errorf("%s was not created", link)
}
}
}
func TestUp_RefusesAnExistingBridgeBeforeStartingQEMU(t *testing.T) {
f := newFixture(t, routerLast)
f.runner.present("lb-underlay")
err := f.lab.Up(context.Background(), f.fetcher, time.Second)
if err == nil || !strings.Contains(err.Error(), "bridge lb-underlay already exists") {
t.Errorf("error = %v", err)
}
if n := len(f.runner.commands("qemu-system-x86_64")); n != 0 {
t.Errorf("%d qemu starts", n)
}
}
func TestUp_StopsWhenTheNetworkFails(t *testing.T) {
f := newFixture(t, routerLast)
f.runner.fail = "ip"
err := f.lab.Up(context.Background(), f.fetcher, time.Second)
if err == nil || err.Error() != "segment underlay: ip failed" {
t.Errorf("error = %v", err)
}
if n := len(f.runner.commands("qemu-system-x86_64")); n != 0 {
t.Errorf("%d qemu starts", n)
}
}
func TestUp_ChecksFRROnVRRPRouters(t *testing.T) {
f := newLab(t, twoSegments, twoRouters)
if err := f.lab.Up(context.Background(), f.fetcher, time.Second); err != nil {
t.Fatalf("Up: %v", err)
}
var checks []string
for _, c := range f.runner.commands("ssh") {
if c[len(c)-4] == "systemctl" {
checks = append(checks, c[indexOf(c, "-p")+1]+" "+strings.Join(c[len(c)-4:], " "))
}
}
want := []string{
"2200 systemctl is-active --quiet frr.service",
"2201 systemctl is-active --quiet frr.service",
}
if !reflect.DeepEqual(checks, want) {
t.Errorf("checks = %q, want %q", checks, want)
}
}
func TestServices(t *testing.T) {
f := newLab(t, twoSegments+underlay, twoRouters+` sw1: { role: router, image: deb, cpus: 1, memory: 512, segments: [underlay], services: [x.service] }
`)
want := map[string][]string{
"r1": {"frr.service"},
"r2": {"frr.service"},
"hv": nil,
"sw1": {"x.service"},
}
for _, n := range f.lab.Plan.Nodes {
if got := services(f.lab.Plan, n); !reflect.DeepEqual(got, want[n.Name]) {
t.Errorf("%s services = %q, want %q", n.Name, got, want[n.Name])
}
}
}