f-95: watchdog: MAC non figée sur le tap signalée #95

Signed-off-by: GnomeZworc <nicolas.boufidjeline@g3e.fr>
This commit is contained in:
GnomeZworc 2026-10-31 21:26:09 +01:00
commit 2f0310d5bc
Signed by: nicolas.boufideline
GPG key ID: 4406BBBF8845D632
2 changed files with 26 additions and 0 deletions

View file

@ -3,12 +3,14 @@ package watchdog
import (
"errors"
"fmt"
"net"
"path/filepath"
"sort"
"strconv"
"strings"
configuration "git.g3e.fr/syonad/two/internal/config/agent"
"git.g3e.fr/syonad/two/internal/netif"
"git.g3e.fr/syonad/two/internal/netns"
"git.g3e.fr/syonad/two/internal/nft"
"git.g3e.fr/syonad/two/internal/qemu"
@ -125,6 +127,8 @@ func checkVMTap(entries map[string]string, prefix, name, vpc string, idx int, n
if err := netns.Call(vpc, func() error {
if p := linkProblem(tapName(tapID)); p != "" {
n.Notify(kindVM, name, p+" (in netns "+vpc+")")
} else if p := tapMACProblem(entries[prefix+"mac"], tapID); p != "" {
n.Notify(kindVM, name, fmt.Sprintf("interface %d: %s (in netns %s)", idx, p, vpc))
}
missing, err := nft.MissingRules(tapPortFromEntries(entries, prefix, tapID))
if err != nil {
@ -140,6 +144,21 @@ func checkVMTap(entries map[string]string, prefix, name, vpc string, idx int, n
}
}
func tapMACProblem(rawMAC string, tapID int) string {
mac, err := net.ParseMAC(rawMAC)
if err != nil {
return fmt.Sprintf("invalid mac %q in database: %v", rawMAC, err)
}
pinned, err := netif.TapHasMAC(tapID, mac)
switch {
case err != nil:
return fmt.Sprintf("fdb of %s unreadable: %v", tapName(tapID), err)
case !pinned:
return fmt.Sprintf("mac %s not pinned on %s (static sticky fdb entry missing)", mac, tapName(tapID))
}
return ""
}
func checkVMQemu(cfg *configuration.Config, name string, n notify.Notifier) {
sock := filepath.Join(cfg.QEMU.QMPDir, name+".sock")
if _, err := qmp.Send(sock, nil); err != nil {

View file

@ -267,3 +267,10 @@ func TestCheckVMs_ClesDeDisqueNeCreentPasDeFausseVM(t *testing.T) {
}
}
}
func TestTapMACProblem_InvalidMACInDatabase(t *testing.T) {
got := tapMACProblem("52:54:00:zz:01:32", 12345678)
if !strings.HasPrefix(got, `invalid mac "52:54:00:zz:01:32" in database`) {
t.Errorf("tapMACProblem = %q", got)
}
}