f-57: watchdog: contrôle de la gateway anycast (macvlan, MAC, adresses) #57

Signed-off-by: GnomeZworc <nicolas.boufidjeline@g3e.fr>
This commit is contained in:
GnomeZworc 2026-10-13 16:00:47 +02:00
commit efad4efc13
Signed by: nicolas.boufideline
GPG key ID: 4406BBBF8845D632
4 changed files with 210 additions and 0 deletions

View file

@ -2,6 +2,7 @@ package netif
import (
"net"
"syscall"
"github.com/vishvananda/netlink"
)
@ -13,3 +14,27 @@ func LinkIsUp(name string) (bool, error) {
}
return link.Attrs().Flags&net.FlagUp != 0, nil
}
func LinkMAC(name string) (net.HardwareAddr, error) {
link, err := netlink.LinkByName(name)
if err != nil {
return nil, err
}
return link.Attrs().HardwareAddr, nil
}
func LinkIPv4(name string) ([]net.IP, error) {
link, err := netlink.LinkByName(name)
if err != nil {
return nil, err
}
addrs, err := netlink.AddrList(link, syscall.AF_INET)
if err != nil {
return nil, err
}
ips := make([]net.IP, 0, len(addrs))
for _, a := range addrs {
ips = append(ips, a.IP)
}
return ips, nil
}

View file

@ -0,0 +1,121 @@
package watchdog
import (
"fmt"
"net"
"strconv"
"strings"
"git.g3e.fr/syonad/two/internal/netif"
"git.g3e.fr/syonad/two/internal/netns"
"git.g3e.fr/syonad/two/internal/watchdog/notify"
"git.g3e.fr/syonad/two/pkg/db/kv"
"github.com/dgraph-io/badger/v4"
)
type gatewayState struct {
MAC string
GatewayAddrs []string
BridgeAddrs []string
}
func hasAddr(addrs []string, ip string) bool {
for _, a := range addrs {
if a == ip {
return true
}
}
return false
}
func gatewayProblems(gw, bridge string, got gatewayState, wantMAC, gatewayIP, relayIP string) []string {
var problems []string
if got.MAC != wantMAC {
problems = append(problems, fmt.Sprintf("interface %s has mac %q, expected anycast %s", gw, got.MAC, wantMAC))
}
if !hasAddr(got.GatewayAddrs, gatewayIP) {
problems = append(problems, fmt.Sprintf("interface %s lacks the gateway address %s", gw, gatewayIP))
}
if !hasAddr(got.BridgeAddrs, relayIP) {
problems = append(problems, fmt.Sprintf("interface %s lacks the relay address %s", bridge, relayIP))
}
if hasAddr(got.BridgeAddrs, gatewayIP) {
problems = append(problems, fmt.Sprintf("interface %s carries the gateway address %s, guests would bypass the anycast mac", bridge, gatewayIP))
}
return problems
}
func readGatewayState(gw, bridge string) (gatewayState, error) {
var st gatewayState
mac, err := netif.LinkMAC(gw)
if err != nil {
return st, err
}
st.MAC = mac.String()
for _, side := range []struct {
iface string
dst *[]string
}{{gw, &st.GatewayAddrs}, {bridge, &st.BridgeAddrs}} {
ips, err := netif.LinkIPv4(side.iface)
if err != nil {
return st, err
}
*side.dst = ipStrings(ips)
}
return st, nil
}
func ipStrings(ips []net.IP) []string {
out := make([]string, 0, len(ips))
for _, ip := range ips {
out = append(out, ip.String())
}
return out
}
func checkAnycastGateway(db *badger.DB, name, vpc, bridge string, n notify.Notifier) {
relayIP, err := kv.GetFromDB(db, prefixSubnet+name+"/relay_ip")
if err != nil || relayIP == "" {
return
}
gatewayIP, err := kv.GetFromDB(db, prefixSubnet+name+"/interface_ip")
if err != nil {
n.Notify(kindSubnet, name, fmt.Sprintf("interface_ip unreadable in database: %v", err))
return
}
raw, err := kv.GetFromDB(db, prefixSubnet+name+"/vxlan_id")
if err != nil {
return
}
vni, err := strconv.Atoi(raw)
if err != nil {
return
}
wantMAC, err := netif.AnycastMAC(vni)
if err != nil {
n.Notify(kindSubnet, name, err.Error())
return
}
if !netns.Exist(vpc) {
return
}
gw := "gw-" + strings.TrimPrefix(bridge, "br-")
if err := netns.Call(vpc, func() error {
if p := linkProblem(gw); p != "" {
n.Notify(kindSubnet, name, p+" (in netns "+vpc+")")
return nil
}
st, err := readGatewayState(gw, bridge)
if err != nil {
n.Notify(kindSubnet, name, fmt.Sprintf("anycast gateway unreadable in netns %s: %v", vpc, err))
return nil
}
for _, p := range gatewayProblems(gw, bridge, st, wantMAC.String(), gatewayIP, relayIP) {
n.Notify(kindSubnet, name, p+" (in netns "+vpc+")")
}
return nil
}); err != nil {
n.Notify(kindSubnet, name, fmt.Sprintf("cannot enter netns %s: %v", vpc, err))
}
}

View file

@ -0,0 +1,61 @@
package watchdog
import (
"strings"
"testing"
)
func TestGatewayProblems_Healthy(t *testing.T) {
st := gatewayState{
MAC: "02:01:00:00:0b:5f",
GatewayAddrs: []string{"10.0.0.254"},
BridgeAddrs: []string{"10.0.0.253"},
}
if p := gatewayProblems("gw-x", "br-x", st, "02:01:00:00:0b:5f", "10.0.0.254", "10.0.0.253"); len(p) != 0 {
t.Errorf("aucun problème attendu, obtenu %v", p)
}
}
func TestGatewayProblems_EachDefectIsReported(t *testing.T) {
healthy := func() gatewayState {
return gatewayState{
MAC: "02:01:00:00:0b:5f",
GatewayAddrs: []string{"10.0.0.254"},
BridgeAddrs: []string{"10.0.0.253"},
}
}
cases := []struct {
label string
mutate func(*gatewayState)
want string
}{
{"MAC du macvlan changée", func(s *gatewayState) { s.MAC = "02:03:c0:a8:0e:0b" }, "expected anycast 02:01:00:00:0b:5f"},
{"gateway absente du macvlan", func(s *gatewayState) { s.GatewayAddrs = nil }, "lacks the gateway address 10.0.0.254"},
{"adresse d'émission absente du bridge", func(s *gatewayState) { s.BridgeAddrs = nil }, "lacks the relay address 10.0.0.253"},
{"gateway posée sur le bridge", func(s *gatewayState) { s.BridgeAddrs = append(s.BridgeAddrs, "10.0.0.254") }, "bypass the anycast mac"},
}
for _, c := range cases {
st := healthy()
c.mutate(&st)
p := gatewayProblems("gw-x", "br-x", st, "02:01:00:00:0b:5f", "10.0.0.254", "10.0.0.253")
if len(p) != 1 || !strings.Contains(p[0], c.want) {
t.Errorf("%s : un problème contenant %q attendu, obtenu %v", c.label, c.want, p)
}
}
}
func TestCheckSubnets_LegacyVxlanHasNoAnycastCheck(t *testing.T) {
db := newTestDB(t)
seedSubnet(t, db, "br-000042", "vp-admin", modeVxlan)
seedKV(t, db, prefixSubnet+"br-000042/vxlan_id", "42")
r := &recorder{}
if err := CheckSubnets(db, dnsmasqConfig(), newFakeUnits(), r); err != nil {
t.Fatalf("erreur inattendue: %v", err)
}
for _, c := range r.calls {
if strings.Contains(c.problem, "gw-") || strings.Contains(c.problem, "anycast") {
t.Errorf("un subnet sans relay_ip ne doit rien signaler sur la gateway anycast : %q", c.problem)
}
}
}

View file

@ -89,6 +89,9 @@ func checkSubnet(db *badger.DB, name string, backend dhcpbackend.Backend, u unit
}
checkSubnetNetns(name, vpc, nsVeth, bridge, n)
if mode == modeVxlan {
checkAnycastGateway(db, name, vpc, bridge, n)
}
checkDHCP(db, name, dhcpbackend.Subnet{Name: name, VPC: vpc, Bridge: bridge}, backend, u, n)
}