diff --git a/cmd/metacli/main.go b/cmd/metacli/main.go index 140bde6..20706d2 100644 --- a/cmd/metacli/main.go +++ b/cmd/metacli/main.go @@ -35,19 +35,15 @@ func main() { defer db.Close() if *start { - if err := metadata.StartMetadata(metadata.NoCloudConfig{ + metadata.StartMetadata(metadata.NoCloudConfig{ VpcName: *vpc, Name: *vm_name, BindIP: *bind_ip, BindPort: *bind_port, Password: *password, SSHKEY: *ssh_key, - }, db, *dryrun); err != nil { - fmt.Println(err) - } + }, db, *dryrun) } else if *stop { - if err := metadata.StopMetadata(*vm_name, db, *dryrun); err != nil { - fmt.Println(err) - } + metadata.StopMetadata(*vm_name, db, *dryrun) } } diff --git a/internal/metadata/handle.go b/internal/metadata/handle.go index 6347d90..33ac088 100644 --- a/internal/metadata/handle.go +++ b/internal/metadata/handle.go @@ -1,41 +1,26 @@ package metadata import ( - "fmt" - "git.g3e.fr/syonad/two/pkg/systemd" "github.com/dgraph-io/badger/v4" ) -func StartMetadata(config NoCloudConfig, db *badger.DB, dryrun bool) error { - service, err := systemd.New() - if err != nil { - return fmt.Errorf("failed to connect to systemd: %w", err) - } +func StartMetadata(config NoCloudConfig, db *badger.DB, dryrun bool) { + service, _ := systemd.New() defer service.Close() LoadNcCloudInDB(config, db) if !dryrun { - fmt.Println("try to start metadata server") - if err := service.Start("metadata@" + config.Name + ".service"); err != nil { - return fmt.Errorf("failed to start metadata@%s: %w", config.Name, err) - } + service.Start("metadata@" + config.Name) } - return nil } -func StopMetadata(vm_name string, db *badger.DB, dryrun bool) error { - service, err := systemd.New() - if err != nil { - return fmt.Errorf("failed to connect to systemd: %w", err) - } +func StopMetadata(vm_name string, db *badger.DB, dryrun bool) { + service, _ := systemd.New() defer service.Close() UnLoadNoCloudInDB(vm_name, db) if !dryrun { - if err := service.Stop("metadata@" + vm_name + ".service"); err != nil { - return fmt.Errorf("failed to stop metadata@%s: %w", vm_name, err) - } + service.Stop("metadata@" + vm_name) } - return nil } diff --git a/pkg/systemd/main.go b/pkg/systemd/main.go index e89af6e..ea5fef0 100644 --- a/pkg/systemd/main.go +++ b/pkg/systemd/main.go @@ -11,7 +11,6 @@ import ( const ( defaultTimeout = 5 * time.Second - jobTimeout = 30 * time.Second jobMode = "replace" ) @@ -29,7 +28,10 @@ type ServiceStatus struct { // New crée une connexion D-Bus systemd (scope système) func New() (*Manager, error) { - conn, err := dbus.NewSystemConnectionContext(context.Background()) + ctx, cancel := context.WithTimeout(context.Background(), defaultTimeout) + defer cancel() + + conn, err := dbus.NewSystemConnectionContext(ctx) if err != nil { return nil, err } @@ -55,17 +57,17 @@ func (m *Manager) Stop(service string) error { } func (m *Manager) job(method, service string) error { - callCtx, callCancel := context.WithTimeout(context.Background(), defaultTimeout) - defer callCancel() + ctx, cancel := context.WithTimeout(context.Background(), defaultTimeout) + defer cancel() ch := make(chan string, 1) var err error switch method { case "StartUnit": - _, err = m.conn.StartUnitContext(callCtx, service, jobMode, ch) + _, err = m.conn.StartUnitContext(ctx, service, jobMode, ch) case "StopUnit": - _, err = m.conn.StopUnitContext(callCtx, service, jobMode, ch) + _, err = m.conn.StopUnitContext(ctx, service, jobMode, ch) default: return errors.New("unsupported job method") } @@ -74,16 +76,9 @@ func (m *Manager) job(method, service string) error { return err } - waitCtx, waitCancel := context.WithTimeout(context.Background(), jobTimeout) - defer waitCancel() - - select { - case result := <-ch: - if result != "done" { - return fmt.Errorf("%s %s failed: %s", method, service, result) - } - case <-waitCtx.Done(): - return fmt.Errorf("%s %s timed out after %s", method, service, jobTimeout) + result := <-ch + if result != "done" { + return fmt.Errorf("%s %s failed: %s", method, service, result) } return nil