f-15: error: add error handle

Signed-off-by: GnomeZworc <nicolas.boufidjeline@g3e.fr>

cmd/metacli/main.go

@@ -35,15 +35,19 @@ func main() {
 	defer db.Close()
 
 	if *start {
-		metadata.StartMetadata(metadata.NoCloudConfig{
+		if err := metadata.StartMetadata(metadata.NoCloudConfig{
 			VpcName:  *vpc,
 			Name:     *vm_name,
 			BindIP:   *bind_ip,
 			BindPort: *bind_port,
 			Password: *password,
 			SSHKEY:   *ssh_key,
-		}, db, *dryrun)
+		}, db, *dryrun); err != nil {
+			fmt.Println(err)
+		}
 	} else if *stop {
-		metadata.StopMetadata(*vm_name, db, *dryrun)
+		if err := metadata.StopMetadata(*vm_name, db, *dryrun); err != nil {
+			fmt.Println(err)
+		}
 	}
 }

internal/metadata/handle.go

@@ -1,26 +1,41 @@
 package metadata
 
 import (
+	"fmt"
+
 	"git.g3e.fr/syonad/two/pkg/systemd"
 	"github.com/dgraph-io/badger/v4"
 )
 
-func StartMetadata(config NoCloudConfig, db *badger.DB, dryrun bool) {
-	service, _ := systemd.New()
+func StartMetadata(config NoCloudConfig, db *badger.DB, dryrun bool) error {
+	service, err := systemd.New()
+	if err != nil {
+		return fmt.Errorf("failed to connect to systemd: %w", err)
+	}
 	defer service.Close()
 
 	LoadNcCloudInDB(config, db)
 	if !dryrun {
-		service.Start("metadata@" + config.Name)
+		fmt.Println("try to start metadata server")
+		if err := service.Start("metadata@" + config.Name + ".service"); err != nil {
+			return fmt.Errorf("failed to start metadata@%s: %w", config.Name, err)
+		}
 	}
+	return nil
 }
 
-func StopMetadata(vm_name string, db *badger.DB, dryrun bool) {
-	service, _ := systemd.New()
+func StopMetadata(vm_name string, db *badger.DB, dryrun bool) error {
+	service, err := systemd.New()
+	if err != nil {
+		return fmt.Errorf("failed to connect to systemd: %w", err)
+	}
 	defer service.Close()
 
 	UnLoadNoCloudInDB(vm_name, db)
 	if !dryrun {
-		service.Stop("metadata@" + vm_name)
+		if err := service.Stop("metadata@" + vm_name + ".service"); err != nil {
+			return fmt.Errorf("failed to stop metadata@%s: %w", vm_name, err)
+		}
 	}
+	return nil
 }

pkg/systemd/main.go

@@ -11,6 +11,7 @@ import (
 
 const (
 	defaultTimeout = 5 * time.Second
+	jobTimeout     = 30 * time.Second
 	jobMode        = "replace"
 )
 
@@ -28,10 +29,7 @@ type ServiceStatus struct {
 
 // New crée une connexion D-Bus systemd (scope système)
 func New() (*Manager, error) {
-	ctx, cancel := context.WithTimeout(context.Background(), defaultTimeout)
-	defer cancel()
-
-	conn, err := dbus.NewSystemConnectionContext(ctx)
+	conn, err := dbus.NewSystemConnectionContext(context.Background())
 	if err != nil {
 		return nil, err
 	}
@@ -57,17 +55,17 @@ func (m *Manager) Stop(service string) error {
 }
 
 func (m *Manager) job(method, service string) error {
-	ctx, cancel := context.WithTimeout(context.Background(), defaultTimeout)
-	defer cancel()
+	callCtx, callCancel := context.WithTimeout(context.Background(), defaultTimeout)
+	defer callCancel()
 
 	ch := make(chan string, 1)
 
 	var err error
 	switch method {
 	case "StartUnit":
-		_, err = m.conn.StartUnitContext(ctx, service, jobMode, ch)
+		_, err = m.conn.StartUnitContext(callCtx, service, jobMode, ch)
 	case "StopUnit":
-		_, err = m.conn.StopUnitContext(ctx, service, jobMode, ch)
+		_, err = m.conn.StopUnitContext(callCtx, service, jobMode, ch)
 	default:
 		return errors.New("unsupported job method")
 	}
@@ -76,9 +74,16 @@ func (m *Manager) job(method, service string) error {
 		return err
 	}
 
-	result := <-ch
-	if result != "done" {
-		return fmt.Errorf("%s %s failed: %s", method, service, result)
+	waitCtx, waitCancel := context.WithTimeout(context.Background(), jobTimeout)
+	defer waitCancel()
+
+	select {
+	case result := <-ch:
+		if result != "done" {
+			return fmt.Errorf("%s %s failed: %s", method, service, result)
+		}
+	case <-waitCtx.Done():
+		return fmt.Errorf("%s %s timed out after %s", method, service, jobTimeout)
 	}
 
 	return nil